Re: [PATCH 1/2] dell-smbios-base: Extends support to Alienware products

From: Pali Rohár
Date: Wed Oct 30 2024 - 14:26:27 EST


On Wednesday 30 October 2024 15:12:45 Kurt Borja wrote:
> Fixes the following error:
>
> dell_smbios: Unable to run on non-Dell system
>
> Which is triggered after dell-wmi driver fails to initialize on
> Alienware systems, as it depends on dell-smbios.
>
> This effectively adds dell-wmi and dell-smbios support to Alienware
> products.
>
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
> drivers/platform/x86/dell/dell-smbios-base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c
> index 73e41eb69..01c72b91a 100644
> --- a/drivers/platform/x86/dell/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell/dell-smbios-base.c
> @@ -576,6 +576,7 @@ static int __init dell_smbios_init(void)
> int ret, wmi, smm;
>
> if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
> + !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) &&

Are we sure that all devices with "Alienware" OEM string supports this SMBIOS API?

> !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
> pr_err("Unable to run on non-Dell system\n");
> return -ENODEV;
> --
> 2.47.0
>