Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

[Andreas Kemnade]

Hi,

a quick first pass of review.

Am Wed, 30 Oct 2024 19:41:32 +0000
schrieb Mithil Bavishi <bavishimithil@xxxxxxxxx>:

> Create common device tree for Samsung Espresso series devices
> 
> Differentiate based on screen sizes, panels, touch controllers,
> and batteries
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@xxxxxxxxx>
> ---
[...]

> +	backlight_pins: pinmux_backlight_pins {

- instead of _ in node names please, also for other places:
    backlight_pins: pinmux-backlight-pins

[...]
> +
> +#include "twl6030.dtsi"
> +
really??? you include both twl6030 and twl6032. That does not make any
sense. Including twl6030_omap4.dtsi might make sense but not
twl6030.dtsi.

Regards,
Andreas