Re: [PATCH v6] rust: add global lock support
From: Miguel Ojeda
Date: Wed Oct 30 2024 - 17:07:31 EST
On Tue, Oct 29, 2024 at 10:12 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> "usually"), I submit my PR at rc2 to rc4, and tip will carry that into
Ah, so you only submit up to -rc4, got it. I didn't know what the cutoff was.
> Got it. This particular one needs to be "// SAFETY: Called exactly
> once", right?
Yeah, with an ending period (pedantic nit, but it is the style we try
to follow).
> For this I'm following the precedents in tip tree: always put the patch
> links at the last line. See the "Commit notifications" in
> Documentation/process/maintainer-tip.rst. (And yeah, I have to manually
> modify this after b4 applies the patches if you have to ask ;-))
That explains it -- thanks! Sounds good (though perhaps the bot should
be amended to agree with `b4`... :)
Cheers,
Miguel