Re: [PATCH v4 1/4] KVM: x86: drop x86.h include from cpuid.h

From: Sean Christopherson
Date: Wed Oct 30 2024 - 20:43:47 EST


On Fri, Sep 06, 2024, Maxim Levitsky wrote:
> Drop x86.h include from cpuid.h to allow the x86.h to include the cpuid.h
> instead.
>
> Also fix various places where x86.h was implicitly included via cpuid.h
>
> Signed-off-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
> ---
> arch/x86/kvm/cpuid.h | 1 -
> arch/x86/kvm/mmu.h | 1 +
> arch/x86/kvm/vmx/hyperv.c | 1 +
> arch/x86/kvm/vmx/nested.c | 2 +-
> arch/x86/kvm/vmx/sgx.c | 3 +--
> 5 files changed, 4 insertions(+), 4 deletions(-)

This missed a necessary include in mtrr.c (maybe only for W=1 builds?)

arch/x86/kvm/mtrr.c:95:5: error: no previous prototype for ‘kvm_mtrr_set_msr’ [-Werror=missing-prototypes]
95 | int kvm_mtrr_set_msr(struct kvm_vcpu *vcpu, u32 msr, u64 data)
| ^~~~~~~~~~~~~~~~
arch/x86/kvm/mtrr.c:110:5: error: no previous prototype for ‘kvm_mtrr_get_msr’ [-Werror=missing-prototypes]
110 | int kvm_mtrr_get_msr(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata)
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors