Re: [PATCH net-next v2 10/15] net: lan969x: add PTP handler function

From: Jakub Kicinski
Date: Wed Oct 30 2024 - 21:07:53 EST


On Thu, 24 Oct 2024 00:01:29 +0200 Daniel Machon wrote:
> + spin_lock_irqsave(&port->tx_skbs.lock, flags);
> + skb_queue_walk_safe(&port->tx_skbs, skb, skb_tmp) {
> + if (SPARX5_SKB_CB(skb)->ts_id != id)
> + continue;
> +
> + __skb_unlink(skb, &port->tx_skbs);
> + skb_match = skb;
> + break;
> + }
> + spin_unlock_irqrestore(&port->tx_skbs.lock, flags);

For a followup for both drivers -- you're mixing irqsave and bare
spin_lock() here. The _irqsave/_irqrestore is not necessary, let's
drop it.

> + spin_lock(&sparx5->ptp_ts_id_lock);