Re: [PATCH][next] wifi: rtw89: 8852a: remove redundant else statement

From: Ping-Ke Shih
Date: Wed Oct 30 2024 - 22:23:21 EST


Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
> On 10/30/2024 6:14 AM, Colin Ian King wrote:
> > The cascaded if statements covers all 16 bit values in the comparisons
> > of dgain and the last else statement is not reachable and hence
> > dead code. Remove it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> > ---
> > drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> > index 9db8713ac99b..f3568c4d0af6 100644
> > --- a/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> > +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c
> > @@ -2248,8 +2248,6 @@ static s8 _dpk_dgain_mapping(struct rtw89_dev *rtwdev, u16 dgain)
> > offset = -9;
> > else if (dgain <= 0x155)
>
> should you drop the test and unconditionally return -12 here?

Agree +1. People don't suspect the else case at first glance.

>
> > offset = -12;
> > - else
> > - offset = 0x0;
> >
> > return offset;
> > }
>