Re: [PATCH v8 1/3] modules: Support extended MODVERSIONS info

From: Luis Chamberlain
Date: Thu Oct 31 2024 - 00:37:10 EST


On Thu, Oct 31, 2024 at 12:22:36PM +1100, Michael Ellerman wrote:
> Matthew Maurer <mmaurer@xxxxxxxxxx> writes:
> > Adds a new format for MODVERSIONS which stores each field in a separate
> > ELF section. This initially adds support for variable length names, but
> > could later be used to add additional fields to MODVERSIONS in a
> > backwards compatible way if needed. Any new fields will be ignored by
> > old user tooling, unlike the current format where user tooling cannot
> > tolerate adjustments to the format (for example making the name field
> > longer).
> >
> > Since PPC munges its version records to strip leading dots, we reproduce
> > the munging for the new format. Other architectures do not appear to
> > have architecture-specific usage of this information.
> >
> > Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> > Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>
> > ---
> > arch/powerpc/kernel/module_64.c | 24 ++++++++++-
>
> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

Michael, Matthew, why make everyone deal with this instead of just
making this an arch thing and ppc would be the only one doing it?

Luis