RE: [PATCH v3 06/10] x86/mce: Break up __mcheck_cpu_apply_quirks()

From: Zhuo, Qiuxu
Date: Thu Oct 31 2024 - 01:19:12 EST


Hi Yazen,

> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> [...]
> > Just from my perspective, no strong preference. 😊
>
> Same here. I just figured this suggestion would be another possible
> cleanup. :)

Thanks for your suggestion. Yes, it does save 3 lines of code.
Either the current patch or your suggestion is OK with me.

Hi @Boris,
may I know which option is OK with you:

Option A (current patch):
struct mca_config *cfg = &mca_cfg;
and then use 'cfg' in apply_quirks_{amd, intel, zhaoxin}()

Option B (suggested by Yazen):
Directly use 'mca_cfg' in apply_quirks_{amd, intel, zhaoxin}()

Thanks!
-Qiuxu