Re: [PATCH v1 1/1] ACPI: battery: Check for error code from devm_mutex_init() call

From: Andy Shevchenko
Date: Thu Oct 31 2024 - 03:08:53 EST


On Wed, Oct 30, 2024 at 12:29:31PM -0600, Thomas Weißschuh wrote:
> Oct 30, 2024 11:31:21 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> > On Wed, Oct 30, 2024 at 10:42:18AM -0600, Thomas Weißschuh wrote:
> >> Oct 30, 2024 10:28:03 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:

...

> >> wouldn't it make sense to mark devm_mutex_init() as __must_check?
> >
> > It's macro, any idea how to do that for the macros?
>
> It should work on __devm_mutex_init().
> I don't think the expression macro  in between should interfere.
> Unfortunately I can't test it myself right now.

Okay, when you have a patch, feel free to Cc me for review.

--
With Best Regards,
Andy Shevchenko