Re: [PATCH 1/2] dt-bindings: rng: add binding for BCM74110 RNG

[Krzysztof Kozlowski]

On 30/10/2024 22:33, Markus Mayer wrote:
> Add a binding for the random number generator used on the BCM74110.
> 
> Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
> ---
>  .../bindings/rng/brcm,bcm74110.yaml           | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm74110.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm74110.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm74110.yaml
> new file mode 100644
> index 000000000000..acd0856cee72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/brcm,bcm74110.yaml

Filename as compatible.

> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rng/brcm,bcm74110.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BCM74110 Random number generator
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Random number generator used on the BCM74110.
> +
> +maintainers:
> +  - Markus Mayer <mmayer@xxxxxxxxxxxx>
> +  - Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm74110-rng

That's not what you have in DTS.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rng: rng@83ba000 {

Drop unused label.



Best regards,
Krzysztof