Re: [PATCH v2 1/4] dt-bindings: arm: qcom-soc: extend to support SAR2130P platform

[Krzysztof Kozlowski]

On Wed, Oct 30, 2024 at 01:50:54PM +0200, Dmitry Baryshkov wrote:
> Extend the patterns in qcom-soc.yaml to support Qualcomm SAR2130P
> platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--

This should be squashed with next patch, adding SAR2130P. It's logically
one change: you bring bindings for SA2130P.


>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index d0751a572af39eecbbd2f8323a6c3c94b3fdeeac..1add7267f541a24e82e0cec62af6f0c839aca267 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -23,7 +23,7 @@ description: |
>  select:
>    properties:
>      compatible:
> -      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+.*$"
> +      pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+.*$"

Instead:
s/sa/sar?/


>    required:
>      - compatible
>  
> @@ -31,7 +31,7 @@ properties:
>    compatible:
>      oneOf:
>        # Preferred naming style for compatibles of SoC components:
> -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1e)[0-9]+(pro)?-.*$"
> +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1e)[0-9]+(p|pro)?-.*$"

This breaks patterns. p|pro should stay as before. 8775p is below:

>        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"

so this pattern could cover your sar, e.g. split:
"^qcom,sc8[0-9]+[a-z][a-z]-.*$"
"^qcom,sar?[0-9]+[a-z]-.*$"

Best regards,
Krzysztof