Re: [PATCH v2 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

From: Krzysztof Kozlowski
Date: Thu Oct 31 2024 - 04:19:42 EST


On Wed, Oct 30, 2024 at 09:18:44PM +0000, Mithil Bavishi wrote:
> Create a device tree for the 3 inch variants (P3100, P3110, P3113)

3 inch variants of what? Describe here the hardware.

>
> Signed-off-by: Mithil Bavishi <bavishimithil@xxxxxxxxx>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


> arch/arm/boot/dts/ti/omap/Makefile | 1 +
> .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++++++++++++++++++
> 2 files changed, 71 insertions(+)
> create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts