Re: [PATCH] USB: serial: Fix use after free in debug printk

From: Johan Hovold
Date: Thu Oct 31 2024 - 05:07:34 EST


On Thu, Oct 31, 2024 at 09:59:10AM +0300, Dan Carpenter wrote:
> The dev_dbg() call dereferences "urb" but it was already freed on the
> previous line. Move the debug output earlier in the function.

Thanks for catching this, but please use a temporary variable for the
struct device pointer instead of changing the flow.

Also make sure to include the driver name in the patch summary prefix
(i.e. "USB: serial: io_edgeport: ..."):

> Fixes: 984f68683298 ("USB: serial: io_edgeport.c: remove dbg() usage")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Johan