Re: [PATCH] driver core: constify devlink class
From: Bartosz Golaszewski
Date: Thu Oct 31 2024 - 08:33:29 EST
On Thu, Oct 24, 2024 at 9:54 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> >
> > On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > >
> > > The devlink class object is never modified and can be made constant.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
>
> Acked-by: Saravana Kannan <saravanak@xxxxxxxxxx>
>
> -Saravana
>
> >
> > > ---
> > > drivers/base/core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > index a84a7b952cfd..0e618d675792 100644
> > > --- a/drivers/base/core.c
> > > +++ b/drivers/base/core.c
> > > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > > }
> > > EXPORT_SYMBOL_GPL(device_link_wait_removal);
> > >
> > > -static struct class devlink_class = {
> > > +static const struct class devlink_class = {
> > > .name = "devlink",
> > > .dev_groups = devlink_groups,
> > > .dev_release = devlink_dev_release,
> > > --
> > > 2.43.0
> > >
Greg, can you pick this one up please?
Bart