Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Sophgo SG2044 ACLINT SSWI
From: Conor Dooley
Date: Thu Oct 31 2024 - 08:39:04 EST
On Thu, Oct 31, 2024 at 02:14:40PM +0800, Inochi Amaoto wrote:
> On Thu, Oct 31, 2024 at 02:08:57PM +0800, Inochi Amaoto wrote:
> > Sophgo SG2044 has a new version of T-HEAD C920, which implement
> > a fully featured T-HEAD ACLINT device. This ACLINT device contains
> > a SSWI device to support fast S-mode IPI.
> >
> > Add necessary compatible string for the T-HEAD ACLINT sswi device.
> >
> > Link: https://www.xrvm.com/product/xuantie/C920
> > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
>
> Hi, Conor,
>
> Could you review it again? I have updated the description of
> the binding and mark the device is T-HEAD specific.
Only thing I would say is that
title: Sophgo sg2044 ACLINT Supervisor-level Software Interrupt Device
should probably be
title: T-Head c900 ACLINT Supervisor-level Software Interrupt Device
or similar, since this isn't Sophgo's IP.
w/ that,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
(dunno if Thomas is willing to change that on application)
Attachment:
signature.asc
Description: PGP signature