Re: [PATCH v3] ext4: prevent data-race that occur when read/write ext4_group_desc structure members
From: Theodore Ts'o
Date: Thu Oct 31 2024 - 10:34:04 EST
On Thu, 03 Oct 2024 21:53:37 +0900, Jeongjun Park wrote:
> Currently, data-race like [1] occur in fs/ext4/ialloc.c
>
> find_group_other() and find_group_orlov() read *_lo, *_hi with
> ext4_free_inodes_count without additional locking. This can cause data-race,
> but since the lock is held for most writes and free inodes value is generally
> not a problem even if it is incorrect, it is more appropriate to use
> READ_ONCE()/WRITE_ONCE() than to add locking.
>
> [...]
Applied, thanks!
[1/1] ext4: prevent data-race that occur when read/write ext4_group_desc structure members
commit: 902cc179c931a033cd7f4242353aa2733bf8524c
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>