Re: [PATCH] ext4: WARN if a full dir leaf block has only one dentry

[Theodore Ts'o]

On Tue, 08 Oct 2024 20:11:52 +0800, libaokun@xxxxxxxxxxxxxxx wrote:
> The maximum length of a filename is 255 and the minimum block size is 1024,
> so it is always guaranteed that the number of entries is greater than or
> equal to 2 when do_split() is called. So unless ext4_dx_add_entry() and
> make_indexed_dir() or some other functions are buggy, 'split == 0' will
> not occur.
> 
> Setting 'continued' to 0 in this case masks the problem that the file
> system has become corrupted, even though it prevents possible out-of-bounds
> access. Hence WARN_ON_ONCE() is used to check if 'split' is 0, and if it is
> then warns and returns an error to abort split.
> 
> [...]

Applied, thanks!

[1/1] ext4: WARN if a full dir leaf block has only one dentry
      commit: 4748df069284704b166b98737352677c525076bd

Best regards,
-- 
Theodore Ts'o <tytso@xxxxxxx>