Re: [PATCH v2 0/2] Fix dtc warnings when building the LAN966x device tree overlay

From: Herve Codina
Date: Thu Oct 31 2024 - 11:05:04 EST


Hi Philipp,


On Tue, 29 Oct 2024 09:43:34 +0100
Herve Codina <herve.codina@xxxxxxxxxxx> wrote:

> dtc generates 3 kinds of warnings when it builds the LAN966x dtso.
>
> - missing or empty reg/ranges property
> .../pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> .../pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> .../pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
> Patch 1 in this series fixes these warnings
>
> - Missing interrupt-parent
> .../pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> This warning was quickly silenced by Philipp [1].
> Patch 2 in this series fixes the warning and should replace the patch
> applied by Philipp to silence the warning.
>
> - Warning (avoid_unnecessary_addr_size)
> /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> This warning should be fixed in dtc.
> A patch has already be sent by Philip to fix it [2].
>
> [1] https://lore.kernel.org/all/57793bb01e02f03e215dfa6f8783df18034ae2ea.camel@xxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@xxxxxxxxxxxxxx/T/#u
>

Both patches in this series have been reviewed by Rob.

I think it is a green light to have them applied in the reset tree.
Your opinion?

Best regards,
Hervé