Re: [PATCH v2] tracing: Replace strncpy() with strscpy() when copying comm

From: Steven Rostedt
Date: Thu Oct 31 2024 - 11:50:48 EST


On Thu, 31 Oct 2024 11:12:06 -0400
Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:

> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1934,7 +1934,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> > max_data->critical_start = data->critical_start;
> > max_data->critical_end = data->critical_end;
> >
> > - strncpy(max_data->comm, tsk->comm, TASK_COMM_LEN);
> > + strscpy(max_data->comm, tsk->comm);
>
> make allyesconfig + make please ?

Or at a minimum, make sure all the code you change is compiled.

-- Steve