Re: [PATCH v1] iio: chemical: bme680: use s16 variable for temp value to avoid casting

From: Jonathan Cameron
Date: Thu Oct 31 2024 - 15:22:29 EST


On Thu, 31 Oct 2024 00:54:24 +0100
Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:

> Use local s16 variable for the temperature channel to avoid casting it
> later before passing it to the bme680_read_temp() function. This way,
> possible endianness and initialization issues are avoided.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>

Applied.

> ---
> drivers/iio/chemical/bme680_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 871921d81e70..6d11f9188367 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c
> @@ -741,6 +741,7 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
> {
> struct bme680_data *data = iio_priv(indio_dev);
> int chan_val, ret;
> + s16 temp_chan_val;
>
> guard(mutex)(&data->lock);
>
> @@ -757,11 +758,11 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
> case IIO_CHAN_INFO_PROCESSED:
> switch (chan->type) {
> case IIO_TEMP:
> - ret = bme680_read_temp(data, (s16 *)&chan_val);
> + ret = bme680_read_temp(data, &temp_chan_val);
> if (ret)
> return ret;
>
> - *val = chan_val * 10;
> + *val = temp_chan_val * 10;
> return IIO_VAL_INT;
> case IIO_PRESSURE:
> ret = bme680_read_press(data, &chan_val);