Re: [PATCH v5 1/1] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin
From: Alexandre Belloni
Date: Thu Oct 31 2024 - 19:00:22 EST
On Tue, 01 Oct 2024 12:22:32 -0400, Frank Li wrote:
> When a new device hotjoins, a new dynamic address is assigned.
> i3c_master_add_i3c_dev_locked() identifies that the device was previously
> attached to the bus and locates the olddev.
>
> i3c_master_add_i3c_dev_locked()
> {
> ...
> olddev = i3c_master_search_i3c_dev_duplicate(newdev);
> ...
> if (olddev) {
> ...
> i3c_dev_disable_ibi_locked(olddev);
> ^^^^^^
> The olddev should not receive any commands on the i3c bus as it
> does not exist and has been assigned a new address. This will
> result in NACK or timeout. So remove it.
> }
>
> [...]
Applied, thanks!
[1/1] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin
https://git.kernel.org/abelloni/c/36faa04ce3d9
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com