Re: [PATCH] gpio: cdev: don't report GPIOs requested as interrupts as used

[Kent Gibson]

On Thu, Oct 31, 2024 at 09:08:41PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> GPIOs used as shared irqs can still be requested by user-space (or
> kernel drivers for that matter) yet we report them as used over the
> chardev ABI. Drop the test for FLAG_USED_AS_IRQ from
> gpio_desc_to_lineinfo().
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

> ---
>  drivers/gpio/gpiolib-cdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 0ec162b0ea04..629e9372fd57 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -2275,7 +2275,6 @@ static void gpio_desc_to_lineinfo(struct gpio_desc *desc,
>  	 */
>  	if (test_bit(FLAG_REQUESTED, &dflags) ||
>  	    test_bit(FLAG_IS_HOGGED, &dflags) ||
> -	    test_bit(FLAG_USED_AS_IRQ, &dflags) ||
>  	    test_bit(FLAG_EXPORT, &dflags) ||
>  	    test_bit(FLAG_SYSFS, &dflags) ||
>  	    !gpiochip_line_is_valid(guard.gc, info->offset)) {
> --
> 2.45.2
>