Re: [PATCH V2 net-next 1/8] net: hibmcge: Add dump statistics supported in this module

[Jakub Kicinski]

On Sat, 26 Oct 2024 19:57:33 +0800 Jijie Shao wrote:
> +	HBG_STATS_REG_I(rx_framesize_64, HBG_REG_RX_PKTS_64OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_65_127,
> +			HBG_REG_RX_PKTS_65TO127OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_128_255,
> +			HBG_REG_RX_PKTS_128TO255OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_256_511,
> +			HBG_REG_RX_PKTS_256TO511OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_512_1023,
> +			HBG_REG_RX_PKTS_512TO1023OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_1024_1518,
> +			HBG_REG_RX_PKTS_1024TO1518OCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_framesize_bt_1518,
> +			HBG_REG_RX_PKTS_1519TOMAXOCTETS_ADDR),
> +	HBG_STATS_REG_I(rx_fcs_error_cnt, HBG_REG_RX_FCS_ERRORS_ADDR),
> +	HBG_STATS_REG_I(rx_data_error_cnt, HBG_REG_RX_DATA_ERR_ADDR),
> +	HBG_STATS_REG_I(rx_align_error_cnt, HBG_REG_RX_ALIGN_ERRORS_ADDR),
> +	HBG_STATS_REG_I(rx_frame_long_err_cnt, HBG_REG_RX_LONG_ERRORS_ADDR),

Please do not dump in ethtool statistics which can be accessed via
standard APIs like ethtool -I, queue_stats or rtnl_stat.
https://docs.kernel.org/next/networking/statistics.html