RE: [PATCH v2 -next] wifi: ipw2x00: fix bad alignments

From: Ping-Ke Shih
Date: Thu Oct 31 2024 - 22:44:23 EST


Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
> This patch fixes incorrect code alignment.
>
> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:2-3: code aligned with following code on line 882.
> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:2-3: code aligned with following code on line 900.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11381
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> -Replace the & in the if statement with &&.

I feel what Kalle meant is like this:

if (ether_addr_equal(hdr->addr3, ieee->bssid) &&
(fc & (IEEE80211_FCTL_TODS + IEEE80211_FCTL_FROMDS)) == 0)