Re: [PATCH net-next v4] net: Implement fault injection forcing skb reallocation

From: Breno Leitao
Date: Fri Nov 01 2024 - 05:56:07 EST


Hello Jakub,

On Thu, Oct 31, 2024 at 05:04:28PM -0700, Jakub Kicinski wrote:
> > > the buffer needs to be null terminated, like:
> > >
> > > skb_realloc.devname[IFNAMSIZ - 1] = '\0';
> > >
> > > no?
> >
> > Yes, but isn't it what the next line do, with strim()?
>
> I could be wrong, but looks like first thing strim does is call strlen()

makes sense. Let me send a v5 with the fixes, and we can continue from
there.

Thanks for the review!
--breno