Re: [PATCH] media: atomisp: Add check for rgby_data memory allocation failure

[Andy Shevchenko]

On Fri, Nov 01, 2024 at 05:57:36PM +0800, Li Huafei wrote:
> On 2024/11/1 16:30, Andy Shevchenko wrote:
> > On Fri, Nov 01, 2024 at 11:48:23PM +0800, Li Huafei wrote:
> >> In ia_css_3a_statistics_allocate(), there is no check on the allocation
> >> result of the rgby_data memory. If rgby_data is not successfully
> >> allocated, it may trigger the assert(host_stats->rgby_data) assertion in
> >> ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue.
> > 
> > Not sure if this code even run on currently supported hardware / firmware,
> > but fix looks okay.
> > 
> >> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> > 
> > No, this is an intermediate commit, you should find the original, which is
> > earlier in the history.
> 
> Apologies, the correct fix tag should be:
> 
> Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
> 
> If this fix can be applied, do I need to send a v2, or can you help add the Fix tag?

Up to Hans, but there is another question left unanswered about SoB chain.
Can you clarify that?

-- 
With Best Regards,
Andy Shevchenko