Re: [PATCH net 2/2] net: enetc: prevent PF from configuring MAC address for an enabled VF

[Vladimir Oltean]

On Thu, Oct 31, 2024 at 02:02:47PM +0800, Wei Fang wrote:
> If PF changes the MAC address of VF after VF is enabled, VF cannot sense
> the change of its own MAC address, and the MAC address in VF's net_device
> is still the original MAC address, which will cause the VF's network to
> not work properly. Therefore, we should restrict PF to configure VF's MAC
> address only when VF is disabled.
> 
> Of course, another solution is to notify VF of this event when PF changes
> VF's MAC address, but the PSI-to-VSI messaging is not implemented in the
> current PF and VF drivers, so this solution is not suitable at present,
> If PSI-to-VSI messaging is supported in the future, we can remove the
> current restriction to enhance the PF's ability to configure the VF's MAC
> address.
> 
> Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>