Re: [PATCH v2 1/2] hung_task: add detect count for hung tasks

From: Lance Yang
Date: Fri Nov 01 2024 - 07:49:16 EST


Hi Andrew,

Sorry, I made a stupid mistake :(

sysctl_hung_task_detect_count is defined as an unsigned long, so we need
to use proc_doulongvec_minmax instead of proc_dointvec to handle it
correctly. Could you please fold the following changes into this patch?

---
kernel/hung_task.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 229ff3d4e501..c18717189f32 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -330,7 +330,7 @@ static struct ctl_table hung_task_sysctls[] = {
.data = &sysctl_hung_task_detect_count,
.maxlen = sizeof(unsigned long),
.mode = 0444,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_doulongvec_minmax,
},
};

--

Thanks,
Lance