Re: [PATCH] arm64: dts: imx8mn-bsh-smm-s2/pro: add simple-framebuffer

[Shawn Guo]

On Fri, Nov 01, 2024 at 07:51:57PM +0800, Shawn Guo wrote:
> On Thu, Oct 24, 2024 at 12:27:56PM +0200, Dario Binacchi wrote:
> > Add a simple-framebuffer node for U-Boot to further fill and activate.
> > 
> > Co-developed-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> > 
> > ---
> > 
> >  .../freescale/imx8mn-bsh-smm-s2-display.dtsi  | 28 +++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > index 7675583a6b67..3d670534a714 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi
> > @@ -4,6 +4,34 @@
> >   */
> >  
> >  / {
> > +	chosen {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		framebuffer-panel0 {
> > +			compatible = "simple-framebuffer";
> > +			clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>, /* lcdif */
> > +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>,
> > +				 <&clk IMX8MN_VIDEO_PLL1>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI_ROOT>, /* pgc_dispmix */
> > +				 <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> > +				 <&clk IMX8MN_CLK_DISP_AXI>,
> > +				 <&clk IMX8MN_CLK_DISP_APB>,
> > +				 <&clk IMX8MN_SYS_PLL2_1000M>,
> > +				 <&clk IMX8MN_SYS_PLL1_800M>,
> > +				 <&clk IMX8MN_CLK_DSI_CORE>, /* mipi_disi */
> > +				 <&clk IMX8MN_CLK_DSI_PHY_REF>;
> > +
> 
> Unneeded newline.
> 
> I dropped it and applied the patch.

I replied too quick.

arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #size-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-display.dtsi:10.3-10: Warning (ranges_format): /chosen:ranges: empty "ranges" property but its #size-cells (1) differs from / (2)

Shawn