Re: [PATCH] sound: fix uninit-value in i2s_dma_isr

[Mark Brown]

On Fri, Nov 01, 2024 at 02:32:43PM +0530, Suraj Sonawane wrote:

> I reviewed the context around val_1 and val_2 in dma_addr_next. These values
> are expected to come from the registers when offlevel is non-zero,
> representing the next DMA address and length information. If offlevel is
> zero, it means there’s no offset data to process, and dma_addr_next might
> not need updating in that case.

> A more precise solution would be to conditionally update prtd->dma_addr_next
> only when offlevel is non-zero, as this would reflect the intended logic
> without relying on an arbitrary initialization.

> Would it be better to revise the patch to conditionally update
> prtd->dma_addr_next only when offlevel is non-zero?

> Let me know if this approach aligns better with the expected behavior.

That seems like a reasonable approach, just skip the update when we
didn't read the values.

Attachment: signature.asc
Description: PGP signature