Re: [PATCH 4/5] rust: reorder `ForeignOwnable` items

[Andreas Hindborg]

"Tamir Duberstein" <tamird@xxxxxxxxx> writes:

> On Thu, Oct 31, 2024 at 8:40 AM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>>
>> On Thu, Oct 31, 2024 at 1:23 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>> >
>> > This change was part of the original patch. Do you prefer the code
>> > movement in the same commit?
>>
>> If we do it, please keep it separate, that is a good idea.
>>
>> However, I think Andreas means to avoid the movement at all,
>> regardless of which commit is used to do it.
>
> Understood. I'll update the commit message to explain that this also
> avoids inconsistency with the implementation in kbox.rs, which is
> already in this order.
>
> Andreas, please let me know if this is acceptable.

I would prefer not to move the code, but I am not going to make more
noise about it that this :) I don't care what order these items are, and
so to me it is just noise in the history.


Best regards,
Andreas Hindborg