Re: [PATCH v2 2/3] spi: apple: Add driver for Apple SPI controller
From: Mark Brown
Date: Fri Nov 01 2024 - 12:08:34 EST
On Fri, Nov 01, 2024 at 03:25:04PM +0100, Janne Grunau via B4 Relay wrote:
> transfer, most of which we do not use right now. Hardware CS control
> is available, but we haven't found a way to make it stay low across
> multiple logical transfers, so we just use software CS control for now.
It is extremely common for hardware CS control to not support multiple
transfers, I wouldn't be surprised if it's simply not possible. We
could potentially use it with compatible messages it seems dubious that
it'd be worth the time/effort of checking and using it only some of the
time.
> +++ b/drivers/spi/spi-apple.c
> @@ -0,0 +1,531 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Apple SoC SPI device driver
> + *
Please make the entire comment block a C++ one so things look more
intentional.
Attachment:
signature.asc
Description: PGP signature