Re: [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574

[Jakub Kicinski]

On Fri, 1 Nov 2024 14:21:24 +0100 Andrew Lunn wrote:
> > +	/* Access to PCS registers such as PCS_MODE_CTRL which are
> > +	 * common to all MIIs, is lock protected and configured
> > +	 * only once. This is required only for interface modes
> > +	 * such as QSGMII.
> > +	 */
> > +	if (interface == PHY_INTERFACE_MODE_QSGMII)
> > +		mutex_lock(&qpcs->config_lock);  
> 
> Is there a lot of contention on this lock? Why not take it for every
> interface mode? It would make the code simpler.

+1
-- 
pw-bot: cr