Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

[Andrew Morton]

On Fri,  1 Nov 2024 19:15:57 +0500 Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> wrote:

> The test should be skipped if initial conditions aren't fulfilled in
> the start instead of failing and outputting non-compliant TAP logs. This
> kind of failure pollutes the results. The initial conditions are:
> - The test should only execute if /tmp file can be allocated.
> - The test should only execute if huge pages are free.

Cc Donet Tom.

I added 

Fixes: 3a103b5315b7 ("selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()")
Cc: <stable@xxxxxxxxxxxxxxx>

> ---
> Before:
> TAP version 13
> 1..4
> Bail out! Error opening file
> : Read-only file system (30)
>  # Planned tests != run tests (4 != 0)
>  # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> After:
> TAP version 13
> 1..0 # SKIP Unable to allocate file: Read-only file system
> ---

And I moved this useful information to the changelog.