Re: [PATCH 2/2] kasan: change kasan_atomics kunit test as KUNIT_CASE_SLOW
From: Andrey Konovalov
Date: Fri Nov 01 2024 - 19:38:58 EST
On Fri, Nov 1, 2024 at 7:40 PM Sabyrzhan Tasbolatov <snovitoll@xxxxxxxxx> wrote:
>
> During running KASAN Kunit tests with CONFIG_KASAN enabled, the
> following "warning" is reported by kunit framework:
>
> # kasan_atomics: Test should be marked slow (runtime: 2.604703115s)
>
> It took 2.6 seconds on my PC (Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz),
> apparently, due to multiple atomic checks in kasan_atomics_helper().
>
> Let's mark it with KUNIT_CASE_SLOW which reports now as:
>
> # kasan_atomics.speed: slow
>
> Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@xxxxxxxxx>
> ---
> mm/kasan/kasan_test_c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
> index 3e495c09342e..3946fc89a979 100644
> --- a/mm/kasan/kasan_test_c.c
> +++ b/mm/kasan/kasan_test_c.c
> @@ -2020,7 +2020,7 @@ static struct kunit_case kasan_kunit_test_cases[] = {
> KUNIT_CASE(kasan_strings),
> KUNIT_CASE(kasan_bitops_generic),
> KUNIT_CASE(kasan_bitops_tags),
> - KUNIT_CASE(kasan_atomics),
> + KUNIT_CASE_SLOW(kasan_atomics),
> KUNIT_CASE(vmalloc_helpers_tags),
> KUNIT_CASE(vmalloc_oob),
> KUNIT_CASE(vmap_tags),
> --
> 2.34.1
>
Reviewed-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>