Re: [PATCH V4 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC
From: kernel test robot
Date: Sat Nov 02 2024 - 06:47:54 EST
Hi Jishnu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6fb2fa9805c501d9ade047fc511961f3273cdcb5]
url: https://github.com/intel-lab-lkp/linux/commits/Jishnu-Prakash/dt-bindings-iio-adc-Move-QCOM-ADC-bindings-to-iio-adc-folder/20241031-030237
base: 6fb2fa9805c501d9ade047fc511961f3273cdcb5
patch link: https://lore.kernel.org/r/20241030185854.4015348-4-quic_jprakash%40quicinc.com
patch subject: [PATCH V4 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20241102/202411021830.6iNtNN1E-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411021830.6iNtNN1E-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411021830.6iNtNN1E-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:31: warning: Cannot understand * @adc_tm: indicates TM type if the channel is used for TM measurements.
on line 31 - I thought it was a doc line
>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: warning: Function parameter or struct member 'dev_data' not described in 'adc5_chip'
>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: warning: Function parameter or struct member 'tm_aux' not described in 'adc5_chip'
vim +31 drivers/iio/adc/qcom-spmi-adc5-gen3.c
29
30 /**
> 31 * @adc_tm: indicates TM type if the channel is used for TM measurements.
32 * @chip: pointer to top-level ADC device structure.
33 */
34
35 struct adc5_channel_prop {
36 struct adc5_channel_common_prop common_props;
37 int adc_tm;
38 struct adc5_chip *chip;
39 };
40
41 /**
42 * struct adc5_chip - ADC private structure.
43 * @dev: SPMI ADC5 Gen3 device.
44 * @num_sdams: number of SDAMs (Shared Direct Access Memory Module) being used.
45 * @nchannels: number of ADC channels.
46 * @chan_props: array of ADC channel properties.
47 * @iio_chans: array of IIO channels specification.
48 * @complete: ADC result notification after interrupt is received.
49 * @lock: ADC lock for access to the peripheral, to prevent concurrent
50 * requests from multiple clients.
51 * @n_tm_channels: number of ADC channels used for TM measurements.
52 * @data: software configuration data.
53 */
54 struct adc5_chip {
55 struct device *dev;
56 struct adc5_device_data dev_data;
57 unsigned int num_sdams;
58 unsigned int nchannels;
59 struct adc5_channel_prop *chan_props;
60 struct iio_chan_spec *iio_chans;
61 struct completion complete;
62 /*
63 * lock for access to the peripheral, to prevent concurrent
64 * requests from multiple clients.
65 */
66 struct mutex lock;
67 const struct adc5_data *data;
68 unsigned int n_tm_channels;
69 struct auxiliary_device *tm_aux;
> 70 };
71
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki