Re: [PATCH 0/2] PCI: {qcom-ep/tegra194}: Move endpoint cleanups to PERST# deassert handler
From: Manivannan Sadhasivam
Date: Sat Nov 02 2024 - 13:11:31 EST
On Sat, Aug 17, 2024 at 11:09:02AM +0530, Manivannan Sadhasivam via B4 Relay wrote:
> Hi,
>
> This series moves the call to endpoint cleanup functions (dw_pcie_ep_cleanup()
> pci_epc_deinit_notify()) to PERST# deassert handler in qcom-ep and tegra194
> drivers. It aims to fix a crash that is seen with Qcom endpoint SoCs when host
> asserts PERST# and the cleanup functions are called without refclk.
>
> During the review of v1 [1], Bjorn suggested fixing up tegra194 driver as well
> as both drivers share the same design and require refclk from host for
> operation.
>
> Testing
> =======
>
> The Qcom patch is tested on SM8450 development board. For tegra194, I'm
> expecting someone in the Cc list or the community will do the testing.
>
> [1] https://lore.kernel.org/linux-pci/20240815224717.GA53536@bhelgaas/
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Can this series be merged for 6.13?
- Mani
> ---
> Manivannan Sadhasivam (2):
> PCI: qcom-ep: Move controller cleanups to qcom_pcie_perst_deassert()
> PCI: tegra194: Move controller cleanups to pex_ep_event_pex_rst_deassert()
>
> drivers/pci/controller/dwc/pcie-qcom-ep.c | 6 ++++--
> drivers/pci/controller/dwc/pcie-tegra194.c | 7 ++++---
> 2 files changed, 8 insertions(+), 5 deletions(-)
> ---
> base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
> change-id: 20240817-pci-qcom-ep-cleanup-740745e21d87
>
> Best regards,
> --
> Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
>
>
--
மணிவண்ணன் சதாசிவம்