RE: [PATCH 05/10] x86/mce/genpool: Make mce_gen_pool_create() return explicit error codes
From: Zhuo, Qiuxu
Date: Sat Nov 02 2024 - 20:42:58 EST
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> [...]
> On Thu, Oct 10 2024 at 23:31, Qiuxu Zhuo wrote:
>
> > Make mce_gen_pool_create() return explicit error codes for better
> > readability.
>
> What's the point?
>
> All error paths including gen_pool_add() return -ENOMEM.
>
> The call site just cares about success or fail.
>
> So this can simply be converted to bool and return true on success and false
> otherwise.
Yes, this way it's much cleaner.
Thank you, Thomas, for your kind guidance.
> Thanks,
>
> tglx