Re: [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc_netmem

[Yunsheng Lin]

On 11/1/2024 9:10 PM, Mina Almasry wrote:

...

> > Isn't it a little odd that old and new are not following the same
> > pattern?
>
> Hi Yunsheng,
>
> The intention is that page_pool_alloc_pages is mirrored by
> page_pool_alloc_netmems.
>
> And page_pool_alloc is mirrored by page_pool_alloc_netmem.
>
> > From your description, the behavior is the same for each function and
> its mirror. What is the gap in the pattern that you see?

I was mostly referring to the API naming pattern.

Isn't it better if page_pool_alloc is mirrored by netmem_pool_alloc and
netmem_pool_alloc_netmems is mirrored by page_pool_alloc_pages() from
API naming prespective?

And maybe page_pool_alloc_frag can be mirrored by netmem_pool_alloc_frag
in the future?

Also, it would be good to update Documentation/networking/page_pool.rst
for those new netmem APIs, or create a new doc file for them.

>