Re: [PATCH v2] implement set_enabled functions on powercap.c

From: kernel test robot
Date: Sun Nov 03 2024 - 11:27:44 EST


Hi Vishnu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v6.12-rc5 next-20241101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Vishnu-Sanal-T/implement-set_enabled-functions-on-powercap-c/20241030-233021
base: https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link: https://lore.kernel.org/r/20241030152706.179779-2-t.v.s10123%40gmail.com
patch subject: [PATCH v2] implement set_enabled functions on powercap.c
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241104/202411040029.mXFFVJ8w-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411040029.mXFFVJ8w-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

lib/powercap.c: In function 'powercap_set_enabled':
>> lib/powercap.c:79:40: warning: '%s' directive writing up to 254 bytes into a region of size 253 [-Wformat-overflow=]
79 | sprintf(command, "echo -n %c > %s", yes_no, path);
| ^~
......
95 | return sysfs_set_enabled(path, mode);
| ~~~~
In function 'sysfs_set_enabled',
inlined from 'powercap_set_enabled' at lib/powercap.c:95:9:
lib/powercap.c:79:9: note: 'sprintf' output between 13 and 267 bytes into a destination of size 265
79 | sprintf(command, "echo -n %c > %s", yes_no, path);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/powercap.c: In function 'powercap_zone_set_enabled':
>> lib/powercap.c:79:40: warning: '%s' directive writing up to 254 bytes into a region of size 253 [-Wformat-overflow=]
79 | sprintf(command, "echo -n %c > %s", yes_no, path);
| ^~
......
203 | return sysfs_set_enabled(path, mode);
| ~~~~
In function 'sysfs_set_enabled',
inlined from 'powercap_zone_set_enabled' at lib/powercap.c:203:9:
lib/powercap.c:79:9: note: 'sprintf' output between 13 and 267 bytes into a destination of size 265
79 | sprintf(command, "echo -n %c > %s", yes_no, path);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki