Re: [PATCH 2/2] MIPS: loongson3_defconfig: Enable blk_dev_nvme by default

From: Krzysztof Kozlowski
Date: Sun Nov 03 2024 - 11:44:29 EST


On 03/11/2024 14:00, WangYuli wrote:
> A significant number of 3A4000 machines come with NVMe drives
> pre-installed, so we should support it in its defconfig.
>
> Tested-by: Erpeng Xu <xuerpeng@xxxxxxxxxxxxx>
> Tested-by: Qiang Ma <maqianga@xxxxxxxxxxxxx>

I am sorry, but what exactly did you test here? This is defconfig, so
you checked whether after building kernel there is such module? This is
not testing.

...

> +CONFIG_BLK_DEV_NVME=m
Best regards,
Krzysztof