Re: [PATCH net-next] net: bnx2x: use ethtool string helpers

[Jakub Kicinski]

On Wed, 30 Oct 2024 13:51:47 -0700 Rosen Penev wrote:
> @@ -3220,13 +3212,13 @@ static void bnx2x_get_strings(struct net_device *dev, u32 stringset, u8 *buf)
>  			start = 0;
>  		else
>  			start = 4;
> -		memcpy(buf, bnx2x_tests_str_arr + start,
> -		       ETH_GSTRING_LEN * BNX2X_NUM_TESTS(bp));
> +		for (i = start; i < BNX2X_NUM_TESTS_SF; i++)
> +			ethtool_puts(&buf, bnx2x_tests_str_arr[i]);

There are three cases - MF, SF and VF. 
You seem to have covered SF and MF, but not VF.
-- 
pw-bot: cr