RE: code From d0f446931dfee7afa9f6ce5b1ac032e4dfa98460 Mon Sep 17 00:00:00 2001

[Leyfoon Tan]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Friday, November 1, 2024 9:31 PM
> To: Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>; Jose Abreu
> <joabreu@xxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Maxime Coquelin
> <mcoquelin.stm32@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-stm32@st-md-
> mailman.stormreply.com; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; lftan.linux@xxxxxxxxx
> Subject: Re: code From d0f446931dfee7afa9f6ce5b1ac032e4dfa98460 Mon Sep
> 17 00:00:00 2001
> 
> On Fri, Nov 01, 2024 at 04:23:33PM +0800, Ley Foon Tan wrote:
> > This patch series fixes the bugs in the dwmac4 drivers:
> >
> > Patch #1: Fix incorrect _SHIFT and _MASK for MTL_OP_MODE_RTC_* macros.
> > Patch #2: Fix bit mask off operation for MTL_OP_MODE_*_MASK.
> > Patch #3: Fix Receive Watchdog Timeout (RWT) interrupt handling.
> >
> > Changes since v1:
> > - Updated CC list from get_maintainers.pl.
> > - Removed Fixes tag.
> 
> It looks to me that the first two patches really are fixes? The last patch is just a
> statistics counter, so probably not a fix?
> 
> If this is correct, please spit these into two series. The first two should target
> net, and have Fixes: tags. The last patch should target net-next, and does not
> need a Fixes: tag.

>From the comment in [1], the fixes for net should be for the user-visible problem. That's why these 3 patches are
resend to net-next.

> 
> > - Add more description in cover letter.
> 
> The Subject: like of the cover letter could be better.

[1] https://patchwork.kernel.org/project/netdevbpf/cover/20241016031832.3701260-1-leyfoon.tan@xxxxxxxxxxxxxxxx/


Regards
Ley Foon