RE: [PATCH 1/2] dt-bindings: power/supply: Add ltc4162-f/s and ltc4015

[Paller, Kim Seer]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Monday, October 28, 2024 7:13 AM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sebastian Reichel <sre@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Mike
> Looijmans <mike.looijmans@xxxxxxxx>
> Subject: Re: [PATCH 1/2] dt-bindings: power/supply: Add ltc4162-f/s and
> ltc4015
> 
> [External]
> 
> On Sun, Oct 27, 2024 at 03:18:51PM +0800, Kim Seer Paller wrote:
> > Add support for ltc4162-f/s and ltc4015
> >
> > - Add compatible entries for ltc4162-f/s and ltc4015
> > - Include datasheets for new devices
> 
> What's the difference between the l, f, and s variants? Please make the commit
> msg describe that rather than what I can read in the diff.

I'll take note of that. Here is the difference between the variants:
LTC4162-L 35V/3.2A Multi-Cell Lithium-Ion Step-Down Battery Charger
LTC4162-F 35V/3.2A Multi-Cell LiFePO4 Step-Down Battery Charger
LTC4162-S 35V/3.2A Lead-Acid Step-Down Battery Charger
LTC4015 35V/3.2A Multichemistry Buck Battery Charger Controller

> 
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/power/supply/ltc4162-l.yaml         | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> > b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> > index 29d536541..9b546150d 100644
> > --- a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> > +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> > @@ -17,12 +17,18 @@ description: |
> >    panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
> >
> >    Specifications about the charger can be found at:
> > +    https://www.analog.com/en/products/ltc4162-l.html
> > +    https://www.analog.com/en/products/ltc4162-f.html
> >      https://www.analog.com/en/products/ltc4162-s.html
> > +    https://www.analog.com/en/products/ltc4015.html
> >
> >  properties:
> >    compatible:
> >      enum:
> >        - lltc,ltc4162-l
> > +      - lltc,ltc4162-f
> > +      - lltc,ltc4162-s
> > +      - lltc,ltc4015
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >