Re: [PATCH v2] btrfs: handle bio_split() error

[Johannes Thumshirn]

On 01.11.24 17:24, John Garry wrote:
>>    
>>    	if (map_length < length) {
>>    		bbio = btrfs_split_bio(fs_info, bbio, map_length);
>> +		if (IS_ERR(bbio)) {
>> +			ret = errno_to_blk_status(PTR_ERR(bbio));
> 
> btrfs_split_bio() does splitting, but error means "goto fail". However
> other failure points "goto fail_split". I find that label naming odd.
> 
> Furthermore, at "fail", we call btrfs_bio_end_io() and that function
> dereferences bbio (which is -EINVAL or something like that)

OK, my stupidity doing something that should be as simple as this patch 
is getting embarrassing.

I'll send a v3 soon.