Re: [PATCH 11/11] staging: gpib: Correct check for max secondary address

From: Dan Carpenter
Date: Mon Nov 04 2024 - 03:09:36 EST


On Sun, Nov 03, 2024 at 10:26:17PM +0100, Dave Penkler wrote:
> GPIB secondary addresses can be between 0 and 31 inclusive
> unlike primary addresses where address 31 is not a valid device
> address. When 31 is used as a primary talk address it
> forms the UNT (Untalk) command and when used as a listener address it
> forms the UNL (Unlisten) commmand.
> The library was incorrectly not allowing a secondary address
> with a value of 31 to be used.
>

This needs a Fixes tag.

> Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>

regards,
dan carpenter