Re: [PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

From: Ban Feng
Date: Mon Nov 04 2024 - 03:20:58 EST


On Tue, Oct 22, 2024 at 11:14 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On 10/22/24 00:20, Christophe JAILLET wrote:
> [ ... ]
> >> + hwmon_dev =
> >> + devm_hwmon_device_register_with_info(dev, client->name, data,
> >> + &nct7363_chip_info, NULL);
> >
> > return devm_hwmon_device_register_with_info()?
> >
>
> No, because the function needs to return an integer, not a pointer.
> And
> return PTR_ERR_OR_ZERO(devm_hwmon_device_register_with_info(...));
> would look a bit awkward.
>
> Guenter
>

Hi Guenter and Christophe,

I'll keep following this driver and check with these suggestions.

Thanks,
Ban