Re: [PATCH 05/11] staging: gpib: Remove GPIB_DEBUG reference and update messaging

[Dan Carpenter]

On Sun, Nov 03, 2024 at 10:26:11PM +0100, Dave Penkler wrote:
> Change pr_alert to dev_alert
> 
> Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>
> ---
>  .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        | 69 +++++++++----------
>  1 file changed, 34 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 4c580137043f..796c3a5be545 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -68,11 +68,8 @@ MODULE_DEVICE_TABLE(usb, skel_table);
>   *	      At module loading:  modprobe lpvo_usb_gpib debug={0,1,2}
>   *	      On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameters/debug
>   */
> -#ifdef GPIB_DEBUG
> -static int debug = 1;
> -#else
> +
>  static int debug;
> -#endif
>  module_param(debug, int, 0644);
>  

Put this in patch #2 instead.

regards,
dan carpenter