Re: [PATCH] media: uvcvideo:Create input device for all uvc devices with status endpoints.
From: kernel test robot
Date: Mon Nov 04 2024 - 05:06:25 EST
Hi chenchangcheng,
kernel test robot noticed the following build errors:
[auto build test ERROR on linuxtv-media-stage/master]
[also build test ERROR on linus/master v6.12-rc6 next-20241101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/chenchangcheng/media-uvcvideo-Create-input-device-for-all-uvc-devices-with-status-endpoints/20241104-104225
base: https://git.linuxtv.org/media_stage.git master
patch link: https://lore.kernel.org/r/20241104023947.826707-1-ccc194101%40163.com
patch subject: [PATCH] media: uvcvideo:Create input device for all uvc devices with status endpoints.
config: x86_64-buildonly-randconfig-001-20241104 (https://download.01.org/0day-ci/archive/20241104/202411041605.VSoO1uus-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241104/202411041605.VSoO1uus-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411041605.VSoO1uus-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/media/usb/uvc/uvc_status.c: In function 'uvc_event_streaming':
>> drivers/media/usb/uvc/uvc_status.c:110:21: error: implicit declaration of function 'uvc_input_has_button' [-Werror=implicit-function-declaration]
110 | if (uvc_input_has_button(dev)) {
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/uvc_input_has_button +110 drivers/media/usb/uvc/uvc_status.c
93
94 /* --------------------------------------------------------------------------
95 * Status interrupt endpoint
96 */
97 static void uvc_event_streaming(struct uvc_device *dev,
98 struct uvc_status *status, int len)
99 {
100 if (len <= offsetof(struct uvc_status, bEvent)) {
101 uvc_dbg(dev, STATUS,
102 "Invalid streaming status event received\n");
103 return;
104 }
105
106 if (status->bEvent == 0) {
107 if (len <= offsetof(struct uvc_status, streaming))
108 return;
109
> 110 if (uvc_input_has_button(dev)) {
111 uvc_dbg(dev, STATUS, "Button (intf %u) %s len %d\n",
112 status->bOriginator,
113 status->streaming.button ? "pressed" : "released", len);
114 uvc_input_report_key(dev, KEY_CAMERA, status->streaming.button);
115 }
116 } else {
117 uvc_dbg(dev, STATUS, "Stream %u error event %02x len %d\n",
118 status->bOriginator, status->bEvent, len);
119 }
120 }
121
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki