Re: [PATCH -next] fs/nfsd: Remove the unused variable sb

[Jeff Layton]

On Mon, 2024-11-04 at 16:21 +0800, Jiapeng Chong wrote:
> Variable sb is not effectively used, so delete it.
> 
> fs/nfsd/nfs4state.c:7988:22: warning: variable ‘sb’ set but not used.
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11648
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>  fs/nfsd/nfs4state.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 5d47a28ef62d..45e487bf0582 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -7986,7 +7986,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>  	struct nfsd4_blocked_lock *nbl = NULL;
>  	struct file_lock *file_lock = NULL;
>  	struct file_lock *conflock = NULL;
> -	struct super_block *sb;
>  	__be32 status = 0;
>  	int lkflg;
>  	int err;
> @@ -8006,7 +8005,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>  	status = fh_verify(rqstp, &cstate->current_fh, S_IFREG, 0);
>  	if (status != nfs_ok)
>  		return status;
> -	sb = cstate->current_fh.fh_dentry->d_sb;
>  
>  	if (lock->lk_is_new) {
>  		if (nfsd4_has_session(cstate))


I would be fine with this, but there are some patches queued for v6.13
in Chuck's tree that start making use of this variable. I suggest that
we don't take this one for now.
-- 
Jeff Layton <jlayton@xxxxxxxxxx>